-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-4477: ArDrive logout issue when switching ArConnect wallets after seed-phrase/json login #1384
Conversation
…ot using arconnect PE-4477
…type; formatting PE-4477
… before triggeering the wallet switch event PE-4477
…g arconnect PE-4477
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review checkpoint
Visit the preview URL for this PR (updated for commit b48646f): https://ardrive-web--pr1384-pe-4477-oxd7z8zy.web.app (expires Thu, 05 Oct 2023 15:02:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lib/authentication/ardrive_auth.dart
Outdated
(await _metadataCache).clear(); | ||
} catch (e) { | ||
logger.e('Failed to logout user', e); | ||
throw AuthenticationFailedException('Failed to logout user'); | ||
} | ||
} | ||
|
||
Future<void> _disconnectFromArConnecct() async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future<void> _disconnectFromArConnecct() async { | |
Future<void> _disconnectFromArConnect() async { |
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/37rqsbo3h2gmo