Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-4477: ArDrive logout issue when switching ArConnect wallets after seed-phrase/json login #1384

Merged
merged 12 commits into from
Sep 28, 2023

Conversation

matibat
Copy link
Contributor

@matibat matibat commented Sep 26, 2023

@matibat matibat self-assigned this Sep 26, 2023
Copy link
Contributor Author

@matibat matibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review checkpoint

lib/app_shell.dart Outdated Show resolved Hide resolved
lib/app_shell.dart Outdated Show resolved Hide resolved
lib/authentication/ardrive_auth.dart Show resolved Hide resolved
lib/authentication/ardrive_auth.dart Outdated Show resolved Hide resolved
lib/authentication/ardrive_auth.dart Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Visit the preview URL for this PR (updated for commit b48646f):

https://ardrive-web--pr1384-pe-4477-oxd7z8zy.web.app

(expires Thu, 05 Oct 2023 15:02:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(await _metadataCache).clear();
} catch (e) {
logger.e('Failed to logout user', e);
throw AuthenticationFailedException('Failed to logout user');
}
}

Future<void> _disconnectFromArConnecct() async {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Future<void> _disconnectFromArConnecct() async {
Future<void> _disconnectFromArConnect() async {

@matibat matibat merged commit aa8e678 into dev Sep 28, 2023
@matibat matibat deleted the PE-4477 branch September 28, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants