Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-4650: Missing 'Detach Drive' option on Android and Mobile WebView #1373

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

matibat
Copy link
Contributor

@matibat matibat commented Sep 20, 2023

@matibat matibat self-assigned this Sep 20, 2023
@github-actions
Copy link

⚠️ Your PR title does not match the required pattern. Please update the title in the format PE-{number}: {description}.

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Visit the preview URL for this PR (updated for commit a8bcfef):

https://ardrive-web--pr1373-detach-drive-button-5iwcvsi1.web.app

(expires Wed, 27 Sep 2023 22:27:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

@matibat matibat changed the title feat(drive detail page): replaces the duplicate more info button with detach drive button for the mobile view PE-4650: Missing 'Detach Drive' option on Android and Mobile WebView Sep 20, 2023
Base automatically changed from PE-4554_detach_icon to dev September 21, 2023 14:19
Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matibat matibat merged commit 3e279e9 into dev Sep 21, 2023
5 of 6 checks passed
@matibat matibat deleted the detach_drive_button_mobile branch September 21, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants