PE-4565: Address the tech debt created by Turbo Promo Code #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matibat
commented
Sep 19, 2023
There was a problem hiding this comment.
For the reviewer - I just split the method into smaller ones. I've set the nullable parameters to be required so I don't miss passing the argument.
| @@ -36,21 +42,6 @@ class PaymentFormLoaded extends PaymentFormState { | |||
| final bool isFetchingPromoCode; | |||
| final bool errorFetchingPromoCode; | |||
|
|
|||
| double? get promoDiscountFactor { | |||
There was a problem hiding this comment.
For the reviewer - this code was being unused.
|
Visit the preview URL for this PR (updated for commit c78f9aa): https://ardrive-web--pr1370-pe-4565-ou9cns27.web.app (expires Tue, 17 Oct 2023 15:10:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up work of #1349 - See the open comments in @thiagocarvalhodev's review.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/51pkhnuc5rnto