Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-4597: adds a description of the selected drive privacy #1366

Merged
merged 8 commits into from
Sep 21, 2023
Merged

Conversation

matibat
Copy link
Contributor

@matibat matibat commented Sep 15, 2023

@matibat matibat self-assigned this Sep 15, 2023
import 'package:ardrive/entities/entities.dart';
import 'package:ardrive/core/arfs/entities/arfs_entities.dart'
show DrivePrivacy;
import 'package:ardrive/entities/constants.dart' as constants;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the class that holds on it the static strings, and use instead the enums?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are implementing the constants for tags, entity types, and more in a couple of new packages: arfs and ardrive_utils that we will release on the large uploads initiative.

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Visit the preview URL for this PR (updated for commit 7f07e6d):

https://ardrive-web--pr1366-pe-4597-c78m2mz1.web.app

(expires Wed, 27 Sep 2023 14:06:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

@matibat
Copy link
Contributor Author

matibat commented Sep 19, 2023

I wrongly committed the fix for the storybug, so I just reverted.

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import 'package:ardrive/entities/entities.dart';
import 'package:ardrive/core/arfs/entities/arfs_entities.dart'
show DrivePrivacy;
import 'package:ardrive/entities/constants.dart' as constants;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are implementing the constants for tags, entity types, and more in a couple of new packages: arfs and ardrive_utils that we will release on the large uploads initiative.

PE-4632: Persistent loading issue when creating drives
@matibat matibat merged commit 668cb18 into dev Sep 21, 2023
@matibat matibat deleted the PE-4597 branch September 21, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants