-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-4597: adds a description of the selected drive privacy #1366
Conversation
import 'package:ardrive/entities/entities.dart'; | ||
import 'package:ardrive/core/arfs/entities/arfs_entities.dart' | ||
show DrivePrivacy; | ||
import 'package:ardrive/entities/constants.dart' as constants; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of the class that holds on it the static strings, and use instead the enums?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are implementing the constants for tags, entity types, and more in a couple of new packages: arfs
and ardrive_utils
that we will release on the large uploads initiative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Visit the preview URL for this PR (updated for commit 7f07e6d): https://ardrive-web--pr1366-pe-4597-c78m2mz1.web.app (expires Wed, 27 Sep 2023 14:06:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
I wrongly committed the fix for the storybug, so I just reverted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
import 'package:ardrive/entities/entities.dart'; | ||
import 'package:ardrive/core/arfs/entities/arfs_entities.dart' | ||
show DrivePrivacy; | ||
import 'package:ardrive/entities/constants.dart' as constants; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are implementing the constants for tags, entity types, and more in a couple of new packages: arfs
and ardrive_utils
that we will release on the large uploads initiative.
PE-4632: Persistent loading issue when creating drives
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/0ujc5gdo66s6o