Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-4582: Audio Preview #1364

Merged
merged 24 commits into from
Sep 27, 2023
Merged

PE-4582: Audio Preview #1364

merged 24 commits into from
Sep 27, 2023

Conversation

kunstmusik
Copy link
Contributor

@kunstmusik kunstmusik commented Sep 14, 2023

Implements audio media player for public audio files.

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/7aarf17abm480

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Visit the preview URL for this PR (updated for commit b0753ab):

https://ardrive-web--pr1364-pe-4582-audio-previe-fv76xiey.web.app

(expires Wed, 04 Oct 2023 13:40:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a few commented codes. I'll finish the review soon!

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@kunstmusik kunstmusik merged commit bbee6c2 into dev Sep 27, 2023
2 checks passed
@kunstmusik kunstmusik deleted the PE-4582-audio-preview-in-app branch September 27, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants