Merge pull request #1848 from ardriveapp/PE-6730

PE-6730: Decouple arns loading from the main upload flow
ardriveapp · Sep 12, 2024 · e3f5ff6 · e3f5ff6
2 parents c1e73f8 + 071a240
commit e3f5ff6
Show file tree

Hide file tree

Showing 4 changed files with 104 additions and 19 deletions.
diff --git a/lib/arns/domain/arns_repository.dart b/lib/arns/domain/arns_repository.dart
@@ -238,7 +238,7 @@ class _ARNSRepository implements ARNSRepository {
     } catch (e) {
       logger.e('Error getting ANT records for wallet: $e');
 
-      _getARNSUndernamesCompleter!.complete([]);
+      _getARNSUndernamesCompleter!.completeError(e);
 
       _getARNSUndernamesCompleter = null;
 

diff --git a/lib/blocs/upload/upload_cubit.dart b/lib/blocs/upload/upload_cubit.dart
@@ -105,24 +105,60 @@ class UploadCubit extends Cubit<UploadState> {
         isNextButtonEnabled: canUpload,
       ));
     } else if (state is UploadReadyToPrepare) {
-      final hasUndernames = (await _arnsRepository
-              .getAntRecordsForWallet(_auth.currentUser.walletAddress))
-          .isNotEmpty;
+      bool showArnsCheckbox = false;
 
-      emit(
-        UploadReady(
-          params: (state as UploadReadyToPrepare).params,
-          paymentInfo: paymentInfo,
-          numberOfFiles: files.length,
-          uploadIsPublic: !_targetDrive.isPrivate,
-          isDragNDrop: isDragNDrop,
-          isNextButtonEnabled: canUpload,
-          isArConnect: (state as UploadReadyToPrepare).isArConnect,
-          showArnsCheckbox:
-              hasUndernames && files.length == 1 && _targetDrive.isPublic,
-          showArnsNameSelection: false,
-        ),
-      );
+      if (_targetDrive.isPublic && files.length == 1) {
+        emit(
+          UploadReady(
+            params: (state as UploadReadyToPrepare).params,
+            paymentInfo: paymentInfo,
+            numberOfFiles: files.length,
+            uploadIsPublic: !_targetDrive.isPrivate,
+            isDragNDrop: isDragNDrop,
+            isNextButtonEnabled: canUpload,
+            isArConnect: (state as UploadReadyToPrepare).isArConnect,
+            showArnsCheckbox: showArnsCheckbox,
+            showArnsNameSelection: false,
+            loadingArNSNames: true,
+          ),
+        );
+
+        try {
+          final hasUndernames = (await _arnsRepository
+                  .getAntRecordsForWallet(_auth.currentUser.walletAddress))
+              .isNotEmpty;
+
+          showArnsCheckbox = hasUndernames;
+
+          if (state is! UploadReady) {
+            logger.d('State is not UploadReady');
+            return;
+          }
+
+          final readyState = state as UploadReady;
+
+          emit(readyState.copyWith(
+              loadingArNSNames: false, showArnsCheckbox: showArnsCheckbox));
+        } catch (e) {
+          final readyState = state as UploadReady;
+          emit(readyState.copyWith(
+              loadingArNSNamesError: true, loadingArNSNames: false));
+        }
+      } else {
+        emit(
+          UploadReady(
+            params: (state as UploadReadyToPrepare).params,
+            paymentInfo: paymentInfo,
+            numberOfFiles: files.length,
+            uploadIsPublic: !_targetDrive.isPrivate,
+            isDragNDrop: isDragNDrop,
+            isNextButtonEnabled: canUpload,
+            isArConnect: (state as UploadReadyToPrepare).isArConnect,
+            showArnsCheckbox: showArnsCheckbox,
+            showArnsNameSelection: false,
+          ),
+        );
+      }
     }
   }
 

diff --git a/lib/blocs/upload/upload_state.dart b/lib/blocs/upload/upload_state.dart
@@ -95,6 +95,8 @@ class UploadReady extends UploadState {
   final UploadParams params;
   final bool showArnsCheckbox;
   final bool showArnsNameSelection;
+  final bool loadingArNSNames;
+  final bool loadingArNSNamesError;
 
   final bool isArConnect;
 
@@ -108,6 +110,8 @@ class UploadReady extends UploadState {
     required this.isArConnect,
     required this.showArnsCheckbox,
     required this.showArnsNameSelection,
+    this.loadingArNSNames = false,
+    this.loadingArNSNamesError = false,
   });
 
   // copyWith
@@ -123,8 +127,11 @@ class UploadReady extends UploadState {
     bool? showSettings,
     bool? showArnsCheckbox,
     bool? showArnsNameSelection,
+    bool? loadingArNSNames,
+    bool? loadingArNSNamesError,
   }) {
     return UploadReady(
+      loadingArNSNames: loadingArNSNames ?? this.loadingArNSNames,
       isArConnect: isArConnect ?? this.isArConnect,
       uploadIsPublic: uploadIsPublic ?? this.uploadIsPublic,
       isDragNDrop: isDragNDrop ?? this.isDragNDrop,
@@ -135,6 +142,8 @@ class UploadReady extends UploadState {
       showArnsCheckbox: showArnsCheckbox ?? this.showArnsCheckbox,
       showArnsNameSelection:
           showArnsNameSelection ?? this.showArnsNameSelection,
+      loadingArNSNamesError:
+          loadingArNSNamesError ?? this.loadingArNSNamesError,
     );
   }
 
@@ -143,6 +152,9 @@ class UploadReady extends UploadState {
         paymentInfo,
         isNextButtonEnabled,
         showArnsNameSelection,
+        loadingArNSNamesError,
+        loadingArNSNames,
+        showArnsCheckbox,
       ];
 
   @override

diff --git a/lib/components/upload_form.dart b/lib/components/upload_form.dart
@@ -629,7 +629,44 @@ class _UploadFormState extends State<UploadForm> {
                             ],
                           ),
                         ),
-                      if (state.showArnsCheckbox)
+                      if (state.loadingArNSNamesError)
+                        Padding(
+                          padding: const EdgeInsets.symmetric(vertical: 8),
+                          child: Row(
+                            children: [
+                              Text(
+                                'Error loading ARNS names',
+                                style: typography.paragraphLarge(
+                                  fontWeight: ArFontWeight.semiBold,
+                                  color: colorTokens.textRed,
+                                ),
+                              ),
+                            ],
+                          ),
+                        ),
+                      if (state.loadingArNSNames)
+                        Padding(
+                          padding: const EdgeInsets.symmetric(vertical: 8),
+                          child: Row(
+                            children: [
+                              Text(
+                                'Loading ArNS names...',
+                                style: typography.paragraphLarge(
+                                  fontWeight: ArFontWeight.semiBold,
+                                ),
+                              ),
+                              const SizedBox(width: 8),
+                              const SizedBox(
+                                height: 16,
+                                width: 16,
+                                child: CircularProgressIndicator(
+                                  strokeWidth: 2,
+                                ),
+                              )
+                            ],
+                          ),
+                        ),
+                      if (state.showArnsCheckbox && !state.loadingArNSNames)
                         Padding(
                           padding: const EdgeInsets.symmetric(vertical: 8),
                           child: Row(