Skip to content

Commit

Permalink
Merge pull request #1664 from ardriveapp/PE-5792-intermittent-visibil…
Browse files Browse the repository at this point in the history
…ity-issue-with-license-column-in-folders

PE-5792: intermittent visibility issue with license column in folders
  • Loading branch information
thiagocarvalhodev authored Mar 12, 2024
2 parents 18bf559 + 4cbbe7c commit 8ba525c
Showing 1 changed file with 42 additions and 39 deletions.
81 changes: 42 additions & 39 deletions lib/pages/drive_detail/components/drive_detail_data_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,52 @@ Widget _buildDataListContent(
}

return LayoutBuilder(builder: (context, constraints) {
final columns = [
TableColumn(
appLocalizationsOf(context).name,
9,
index: 0,
canHide: false,
),
if (constraints.maxWidth > 500)
TableColumn(
appLocalizationsOf(context).size,
3,
index: 1,
canHide: false,
),
if (constraints.maxWidth > 640)
TableColumn(
appLocalizationsOf(context).lastUpdated,
3,
index: 2,
isVisible: columnVisibility[2] ?? true,
),
if (constraints.maxWidth > 700)
TableColumn(
appLocalizationsOf(context).dateCreated,
3,
index: 3,
isVisible: columnVisibility[3] ?? true,
),
if (constraints.maxWidth > 820)
TableColumn(
// TODO: Localize
// appLocalizationsOf(context).licenseType,
'License',
2,
index: 4,
isVisible: columnVisibility[4] ?? true,
),
];

final driveDetailCubitState = context.read<DriveDetailCubit>().state;
final forceRebuildKey = driveDetailCubitState is DriveDetailLoadSuccess
? driveDetailCubitState.forceRebuildKey
: null;
return ArDriveDataTable<ArDriveDataTableItem>(
key: ValueKey('${folder.id}-${forceRebuildKey.toString()}'),
key: ValueKey(
'${folder.id}-${forceRebuildKey.toString()}${columns.length}'),
lockMultiSelect: context.watch<SyncCubit>().state is SyncInProgress ||
!context.watch<ActivityTracker>().isMultiSelectEnabled,
rowsPerPageText: appLocalizationsOf(context).rowsPerPage,
Expand Down Expand Up @@ -186,44 +226,7 @@ Widget _buildDataListContent(
},
forceDisableMultiSelect:
context.read<DriveDetailCubit>().forceDisableMultiselect,
columns: [
TableColumn(
appLocalizationsOf(context).name,
9,
index: 0,
canHide: false,
),
if (constraints.maxWidth > 500)
TableColumn(
appLocalizationsOf(context).size,
3,
index: 1,
canHide: false,
),
if (constraints.maxWidth > 640)
TableColumn(
appLocalizationsOf(context).lastUpdated,
3,
index: 2,
isVisible: columnVisibility[2] ?? true,
),
if (constraints.maxWidth > 700)
TableColumn(
appLocalizationsOf(context).dateCreated,
3,
index: 3,
isVisible: columnVisibility[3] ?? true,
),
if (constraints.maxWidth > 820)
TableColumn(
// TODO: Localize
// appLocalizationsOf(context).licenseType,
'License',
2,
index: 4,
isVisible: columnVisibility[4] ?? true,
),
],
columns: columns,
trailing: (file) => isMultiselecting
? const SizedBox.shrink()
: DriveExplorerItemTileTrailing(
Expand Down

0 comments on commit 8ba525c

Please sign in to comment.