Merge pull request #1492 from ardriveapp/PE-5015_leftover

PE-5131: ArConnect logout leftover
ardriveapp · Nov 28, 2023 · 66c7aaa · 66c7aaa
2 parents 20703df + 4087e48
commit 66c7aaa
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/lib/authentication/ardrive_auth.dart b/lib/authentication/ardrive_auth.dart
@@ -237,12 +237,16 @@ class ArDriveAuthImpl implements ArDriveAuth {
   }
 
   Future<void> _disconnectFromArConnect() async {
-    final hasArConnectPermissions = await _arConnectService.checkPermissions();
-    if (hasArConnectPermissions) {
-      try {
-        await _arConnectService.disconnect();
-      } catch (e) {
-        logger.e('Failed to disconnect from ArConnect', e);
+    final isExtensionAvailable = _arConnectService.isExtensionPresent();
+    if (isExtensionAvailable) {
+      final hasArConnectPermissions =
+          await _arConnectService.checkPermissions();
+      if (hasArConnectPermissions) {
+        try {
+          await _arConnectService.disconnect();
+        } catch (e) {
+          logger.e('Failed to disconnect from ArConnect', e);
+        }
       }
     }
   }

diff --git a/lib/components/profile_card.dart b/lib/components/profile_card.dart
@@ -367,9 +367,12 @@ class __LogoutButtonState extends State<_LogoutButton> {
       },
       child: InkWell(
         onTap: () {
-          context.read<ArDriveAuth>().logout().then(
+          final arDriveAuth = context.read<ArDriveAuth>();
+          final profileCubit = context.read<ProfileCubit>();
+
+          arDriveAuth.logout().then(
             (value) {
-              context.read<ProfileCubit>().logoutProfile();
+              profileCubit.logoutProfile();
               PlausibleEventTracker.track(event: PlausibleEvent.logout);
             },
           );

diff --git a/test/authentication/ardrive_auth_test.dart b/test/authentication/ardrive_auth_test.dart
@@ -59,6 +59,9 @@ void main() {
     when(() => mockArConnectService.checkPermissions()).thenAnswer(
       (invocation) => Future.value(true),
     );
+    when(() => mockArConnectService.isExtensionPresent()).thenAnswer(
+      (invocation) => true,
+    );
     when(() => mockArConnectService.disconnect()).thenAnswer(
       (invocation) => Future.value(null),
     );