Merge pull request #1855 from ardriveapp/PE-6743

PE-6743: increase page size syncing arns names and get from cache
ardriveapp · Sep 13, 2024 · 2b42268 · 2b42268
2 parents 5d0962f + aaaf00d
commit 2b42268
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 34 deletions.
diff --git a/lib/arns/domain/arns_repository.dart b/lib/arns/domain/arns_repository.dart
@@ -201,6 +201,8 @@ class _ARNSRepository implements ARNSRepository {
     if (_getARNSUndernamesCompleter != null) {
       return _getARNSUndernamesCompleter!.future;
     }
+    logger.d('Loading names');
+    final date = DateTime.now();
 
     _getARNSUndernamesCompleter = Completer();
 
@@ -244,6 +246,9 @@ class _ARNSRepository implements ARNSRepository {
 
       lastUpdated = DateTime.now();
 
+      logger.d(
+          'Names loaded in ${DateTime.now().difference(date).inMilliseconds}ms');
+
       _getARNSUndernamesCompleter!.complete(records);
 
       _getARNSUndernamesCompleter = null;

diff --git a/lib/arns/presentation/assign_name_bloc/assign_name_bloc.dart b/lib/arns/presentation/assign_name_bloc/assign_name_bloc.dart
@@ -27,13 +27,9 @@ class AssignNameBloc extends Bloc<AssignNameEvent, AssignNameState> {
       emit(LoadingNames());
 
       final walletAddress = await _auth.getWalletAddress();
-      if (!event.updateARNSRecords) {
-        await _arnsRepository.waitForARNSRecordsToUpdate();
-      }
 
       final names = await _arnsRepository.getAntRecordsForWallet(
         walletAddress!,
-        update: event.updateARNSRecords,
       );
 
       if (names.isEmpty) {

diff --git a/lib/blocs/create_manifest/create_manifest_cubit.dart b/lib/blocs/create_manifest/create_manifest_cubit.dart
@@ -60,12 +60,6 @@ class CreateManifestCubit extends Cubit<CreateManifestState> {
       // Private manifests need more consideration and are currently unavailable
       emit(CreateManifestPrivacyMismatch());
     }
-
-    // updates the ARNS records
-    _arnsRepository.getAntRecordsForWallet(
-      _auth.currentUser.walletAddress,
-      update: true,
-    );
   }
 
   void selectUploadMethod(
@@ -98,10 +92,8 @@ class CreateManifestCubit extends Cubit<CreateManifestState> {
   ) async {
     final revisionConfirmationState = state as CreateManifestRevisionConfirm;
 
-    final arns = await _arnsRepository.getAntRecordsForWallet(
-      _auth.currentUser.walletAddress,
-      update: false,
-    );
+    final arns = await _arnsRepository
+        .getAntRecordsForWallet(_auth.currentUser.walletAddress);
 
     if (arns.isNotEmpty) {
       emit(
@@ -181,8 +173,7 @@ class CreateManifestCubit extends Cubit<CreateManifestState> {
 
   Future<void> checkNameConflicts(String name) async {
     final arns = await _arnsRepository.getAntRecordsForWallet(
-      _auth.currentUser.walletAddress,
-      update: false,
+      _auth.currentUser.walletAddress
     );
 
     final parentFolder =

diff --git a/lib/blocs/upload/upload_cubit.dart b/lib/blocs/upload/upload_cubit.dart
@@ -317,10 +317,7 @@ class UploadCubit extends Cubit<UploadState> {
   Future<void> startUploadPreparation({
     bool isRetryingToPayWithTurbo = false,
   }) async {
-    _arnsRepository.getAntRecordsForWallet(
-      _auth.currentUser.walletAddress,
-      update: true,
-    );
+    _arnsRepository.getAntRecordsForWallet(_auth.currentUser.walletAddress);
 
     files.removeWhere((file) => filesNamesToExclude.contains(file.ioFile.name));
     _targetDrive = await _driveDao.driveById(driveId: driveId).getSingle();

diff --git a/packages/ario_sdk/web/dist/index.js b/packages/ario_sdk/web/dist/index.js
@@ -129805,7 +129805,7 @@ async function $6efb768676258e07$var$getProcesses(address) {
         });
         arnsEmitter.fetchProcessesOwnedByWallet({
             address: address,
-            pageSize: 100
+            pageSize: 10000
         });
     });
 }

diff --git a/packages/ario_sdk/web/dist/index.js.map b/packages/ario_sdk/web/dist/index.js.map
diff --git a/packages/ario_sdk/web/src/index.js b/packages/ario_sdk/web/src/index.js
@@ -153,7 +153,7 @@ async function getProcesses(address) {
 
     arnsEmitter.fetchProcessesOwnedByWallet({
       address: address,
-      pageSize: 100
+      pageSize: 10000
     });
   });
 }
diff --git a/test/arns/presentation/assign_name_bloc/assign_name_bloc_test.dart b/test/arns/presentation/assign_name_bloc/assign_name_bloc_test.dart
@@ -57,8 +57,8 @@ void main() {
 
         when(() => mockAuth.getWalletAddress())
             .thenAnswer((_) async => walletAddress);
-        when(() => mockArnsRepository.getAntRecordsForWallet(walletAddress,
-            update: true)).thenAnswer((_) async => antRecords);
+        when(() => mockArnsRepository.getAntRecordsForWallet(walletAddress))
+            .thenAnswer((_) async => antRecords);
 
         // Act
         assignNameBloc.add(const LoadNames());
@@ -74,8 +74,9 @@ void main() {
         );
 
         verify(() => mockAuth.getWalletAddress()).called(1);
-        verify(() => mockArnsRepository.getAntRecordsForWallet(walletAddress,
-            update: true)).called(1);
+        verify(() => mockArnsRepository.getAntRecordsForWallet(
+              walletAddress,
+            )).called(1);
       });
 
       test(
@@ -87,8 +88,8 @@ void main() {
 
         when(() => mockAuth.getWalletAddress())
             .thenAnswer((_) async => walletAddress);
-        when(() => mockArnsRepository.getAntRecordsForWallet(walletAddress,
-            update: true)).thenAnswer((_) async => antRecords);
+        when(() => mockArnsRepository.getAntRecordsForWallet(walletAddress))
+            .thenAnswer((_) async => antRecords);
 
         // Act
         assignNameBloc.add(const LoadNames());
@@ -103,8 +104,9 @@ void main() {
         );
 
         verify(() => mockAuth.getWalletAddress()).called(1);
-        verify(() => mockArnsRepository.getAntRecordsForWallet(walletAddress,
-            update: true)).called(1);
+        verify(() => mockArnsRepository.getAntRecordsForWallet(
+              walletAddress,
+            )).called(1);
       });
     });
 
@@ -294,8 +296,8 @@ void main() {
 
           when(() => mockAuth.getWalletAddress())
               .thenAnswer((_) async => walletAddress);
-          when(() => mockArnsRepository.getAntRecordsForWallet(walletAddress,
-              update: true)).thenAnswer((_) async => antRecords);
+          when(() => mockArnsRepository.getAntRecordsForWallet(walletAddress))
+              .thenAnswer((_) async => antRecords);
           when(() => mockArnsRepository.setUndernamesToFile(
                 undername: any(named: 'undername'),
                 fileId: any(named: 'fileId'),

diff --git a/web/js/ario_sdk.min.js b/web/js/ario_sdk.min.js