PE-5005: fix(contract reader): switch to a PDS managed default contract cache #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| export class VertoContractReader implements ContractReader { | ||
| export class ArNSMicroserviceContractReader implements ContractReader { |
There was a problem hiding this comment.
It's a generalized contract cache with some ArNS-specific APIs available. Can we just refer to this as PDSContractCacheServiceContractReader?
There was a problem hiding this comment.
I can see how the domain name might push us in this direction though...
arielmelendez
previously approved these changes
Nov 10, 2023
arielmelendez
approved these changes
Nov 10, 2023
fedellen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes an issue we're seeing with the default contract reader when fetching the ardrive contract when determining the community tip during uploads
as we were forewarned, it seems the Verto contract cache is no longer publicly available. fortunately PDS is now hosting our own contract cache, the ArNS Microservice -- here we switch to using that cache