Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cssmin using poetry compatible URL #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Install cssmin using poetry compatible URL #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-e git+git://github.com/fredj/cssmin.git@master#egg=cssmin
git+https://github.com/fredj/cssmin.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the documentation it seems for pip #egg=cssmin is required so can't it be kept? Why would poetry not understand something pip makes up?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the point was removing the -e which poetry can't handle, not sure why the egg spec is being removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it and poetry can't handle that @master either which is rather sad

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would raise an issue with pip for deprecating #egg=cssmin suffix that looks like a hack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is absolutely not. And it is already deprecated as eggs themselves are deprecated.
https://pip.pypa.io/en/stable/reference/pip_install/#vcs-support

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely not what?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is absolutely not a hack.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Press 😄 if #egg is a hack, and 🎉 if it is not. )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to argue if this is or is not a hack, but please do not go open issues for features very deliberately documented. This is open source and I assure you all the pip maintainers, as is usual on open source projects, are busy, you will only be wasting their already limited time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using poetry. So, what is the consensus Are you going to merge this? )

Django==3.1.3
IPy==1.00
Markdown==3.2.2
Expand Down