Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean translation #75

Open
wants to merge 4 commits into
base: feature
Choose a base branch
from

Conversation

Hackjjang
Copy link

@Hackjjang Hackjjang commented Aug 18, 2023

image

I'd like to contribute to making the tool more accessible to people with Korean accessibility.

@Hackjjang
Copy link
Author

Is there a specific reason why it won't merge?

@arch1t3cht
Copy link
Owner

I'm very hesitant about merging PRs updating translations to languages I don't speak, since I can't check myself if they are correct. They're also a bit out of scope for this fork, which mostly collects bugfixes and new features - translation updates would fit better in a more central place like upstream.

I don't mind this PR being open here - that way people can use it for whatever they might need it for - but for now I can't really merge it, sorry.

@Hackjjang
Copy link
Author

I think it would be better to merge it and get some feedback.
I've been doing Korean localisation for PCSX2, DuckStation, Cemu, etc.
I've also done subtitling in the past, and I've been getting feedback on my translations through my blog (although I've only gotten feedback once...).

@Hackjjang
Copy link
Author

If the reason is that the existing translation has a lot of mistranslations and untranslated parts, and you can't check the translation problem, it's better to delete it except for the languages you can manage.

@Hackjjang
Copy link
Author

I wouldn't have translated it if I didn't think it would be reflected like this...
I've done something wrong...

@Hackjjang
Copy link
Author

Why not approve it first and see what users think?

@arch1t3cht arch1t3cht force-pushed the feature branch 2 times, most recently from b54f508 to a455e07 Compare April 3, 2024 16:30
@arch1t3cht arch1t3cht force-pushed the feature branch 3 times, most recently from 914ad0e to 0e44a34 Compare May 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants