-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proposition] code adaptation #9
Conversation
Add some dummy test on omd namespace
Once melpa/melpa#2568 is merged, it will make sense.
Hello, Please, when you'll have time, tell me if something is wrong The context is:
So i think I simply could learn a thing or 2 with this and why not help in maintaining this. Also to clarify this
(It's not show-off) Cask is quite helpful and simple enough to use once the setup is done. Cheers, |
Thank you a lot for this amazing contribution! As said I'm rather new in Emacs package development, so I appreciate your effort and the willingness to help. Let me review your code! I'll do it soon. |
Cool.
Like anything new, another environment is rather overwhelming at first :D
Great! Cheers, |
|
||
for i in org-sync*.el; do | ||
sed -e $regexp_os -i $i | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need this script in the repo? It was probably a one time conversion action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, no.
It's just to be transparent on how how i did it.
I did that and check everything worked out ok after that.
Now that you've seen it, off with its head :D
(depends-on "ert-runner") | ||
(depends-on "ert") | ||
(depends-on "ert-expectations") | ||
(depends-on "el-mock")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a Cask file is obviously a big plus!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also permits to make package.
I use it to make the package and send them to marmalade https://marmalade-repo.org/ (another package repository)
0cfc9ea
to
c5c3409
Compare
Ok, thank you so much! We'll try to polish this project further! |
Code adaptations to comply with naming convintions.
Cool. |
Thanks to both of you for your work on org-sync. Even if the original author expressed doubts on its usefulness and maintainability, I think it's great to use it as a sandbox for ideas on how to connect org-mode with the outside world of bugtrackers. |
Thanks!
Indeed. |
Hello,
As you ask for help in melpa/melpa#2568, I took the liberty of trying to:
So now every function of org-sync.el starts with
org-sync-
,org-sync-github.el
starts withorg-sync-github-
, etc...test/
folder and trigger them viamake test
. It adds a test dependencies cask/cask. As a next step, we could add tests and travis-ci.Manual check
As there is no test yet and i cannot in just one evening add tests everywhere, i did a basic manual test before and after the modification.
I created an issues.org before and after the change with org-trello/org-trello url repository and got everything. The result can be seen https://github.com/ardumont/org/blob/master/org-trello/issues.org.
Cheers,