Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for /arana/pkg/config/file/file.go #808

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Dec 10, 2023

What this PR does:

Which issue(s) this PR fixes:

For #791

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@dongzl dongzl added the test Unit test. label Dec 10, 2023
@dongzl dongzl added this to the 0.3.0 milestone Dec 10, 2023
Copy link

cr-gpt bot commented Dec 10, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@dongzl dongzl changed the title add unit test for /arana/pkg/config/file/file.go add unit test for /arana/pkg/config/file/file.go Dec 10, 2023
Copy link

sonarcloud bot commented Dec 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f62d64) 40.42% compared to head (f5bf984) 40.48%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
+ Coverage   40.42%   40.48%   +0.05%     
==========================================
  Files         265      265              
  Lines       26711    26711              
==========================================
+ Hits        10799    10813      +14     
+ Misses      14746    14734      -12     
+ Partials     1166     1164       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexStocks AlexStocks merged commit 35d9d72 into arana-db:master Dec 10, 2023
12 checks passed
@dongzl dongzl deleted the add-unit-test branch January 26, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants