Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Please Enable Issues Tab #1

Closed
wants to merge 1 commit into from
Closed

Create Please Enable Issues Tab #1

wants to merge 1 commit into from

Conversation

dandv
Copy link

@dandv dandv commented Nov 13, 2014

Saw this package on Atmosphere at https://atmospherejs.com/aramk/d3

How does it compare to existing d3 wrappers like https://atmospherejs.com/garrilla/d3 ?

@aramk
Copy link
Owner

aramk commented Nov 13, 2014

I find it's usually a better idea to fork the original package rather than use submodules or worse copy it directly, because it allows you to modify the script to support Meteor (if necessary) and you can still pull upstream new versions from the main branch without having to re-apply your changes. See http://www.meteorpedia.com/read/Packaging_existing_Libraries.

@aramk aramk closed this Nov 13, 2014
@dandv dandv deleted the patch-1 branch November 14, 2014 05:26
@dandv
Copy link
Author

dandv commented Nov 14, 2014

@paralin has argued quite convincingly that it's even better than wrapping to use meteor-bower whenever possible.

Atmosphere is indeed full of abandoned wrapper packages.

@aramk
Copy link
Owner

aramk commented Nov 14, 2014

I definitely agree with that argument. The only packages from users on atmosphere should be their own packages, not wrapped ones with minor differences. I'll give meteor-bower a try at some point. I suppose using npm for server-side dependencies rather than using meteor wrappers around them would also be a good idea.

@dandv
Copy link
Author

dandv commented Nov 25, 2014

Hey @aramk - I'm submitted an official PR to @mbostock, see MeteorCommunity/discussions#14 (comment)

Maybe time to unpublish this package?

meteor admin set-unmigrated aramk:d3

Thanks!

@dandv
Copy link
Author

dandv commented Nov 30, 2014

d3js:d3 now has 9 stars. Would you like to unmigrate aramk:d3?

@dandv
Copy link
Author

dandv commented Nov 30, 2014

BTW, I think it was your idea that forking is even better than submodules, that led me to write the now quite popular Official Meteor integration thread, which brought us direct integrations from Moment.js, and (almost there), Font-Awesome and d3. Thank you.

@aramk
Copy link
Owner

aramk commented Dec 1, 2014

That sounds like a good idea, I'll unmigrate now. Thanks for your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants