-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buidler migration #59
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,31 @@ | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's remove this extra newline :) |
||
{ | ||
"presets": [ | ||
[ | ||
"@babel/preset-env", | ||
{ | ||
"modules": false, | ||
"targets": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I forget exactly, but is the browserlist in the package.json enough or do we need to specify |
||
"browsers": [ | ||
"> 1%", | ||
"last 3 versions", | ||
"ie >= 9", | ||
"ios >= 8", | ||
"android >= 4.2" | ||
] | ||
}, | ||
"useBuiltIns": "entry", | ||
"core-js": 3, | ||
"corejs": 3, | ||
"shippedProposals": true, | ||
} | ||
] | ||
], | ||
"plugins": [ | ||
"@babel/plugin-proposal-class-properties", | ||
[ | ||
"styled-components", | ||
{ | ||
"displayName": true | ||
} | ||
] | ||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
const { usePlugin } = require('@nomiclabs/buidler/config') | ||
const hooks = require('./scripts/buidler-hooks') | ||
|
||
usePlugin('@aragon/buidler-aragon') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this plugin is not really in active development anymore, what do you think about removing any configuration or dependencies that rely on it? Or was this still essential to your workflow? |
||
usePlugin('@nomiclabs/buidler-solhint') | ||
usePlugin('buidler-gas-reporter') | ||
usePlugin('solidity-coverage') | ||
|
||
const ACCOUNTS = (process.env.ETH_KEYS ? process.env.ETH_KEYS.split(',') : []) | ||
.map(key => key.trim()) | ||
|
||
module.exports = { | ||
defaultNetwork: 'localhost', | ||
networks: { | ||
localhost: { | ||
url: 'http://localhost:8545', | ||
accounts: { | ||
mnemonic: "explain tackle mirror kit van hammer degree position ginger unfair soup bonus" | ||
} | ||
}, | ||
mainnet: { | ||
url: 'https://mainnet.eth.aragon.network', | ||
accounts: ACCOUNTS, | ||
}, | ||
// Rinkeby network configured with Aragon node. | ||
rinkeby: { | ||
url: 'https://rinkeby.eth.aragon.network', | ||
accounts: ACCOUNTS, | ||
}, | ||
// Network configured to interact with Frame wallet. Requires | ||
// to have Frame running on your machine. Download it from: | ||
// https://frame.sh | ||
frame: { | ||
httpHeaders: { origin: 'buidler' }, | ||
url: 'http://localhost:1248', | ||
}, | ||
xdai:{ | ||
url: 'https://xdai.poanetwork.dev', | ||
accounts: ACCOUNTS, | ||
gasPrice: 20, | ||
gas: 12000000, | ||
}, | ||
coverage: { | ||
url: 'http://localhost:8555', | ||
}, | ||
}, | ||
solc: { | ||
version: '0.4.24', | ||
optimizer: { | ||
enabled: true, | ||
runs: 10000, | ||
}, | ||
}, | ||
gasReporter: { | ||
enabled: process.env.GAS_REPORTER ? true : false, | ||
}, | ||
aragon: { | ||
appServePort: 8001, | ||
clientServePort: 3000, | ||
appSrcPath: 'app/', | ||
appBuildOutputPath: 'dist/', | ||
hooks, | ||
}, | ||
} |
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is this from the new solidity-coverage version? Can we remove some of the previous lines on ignoring the previous version's coverage output?