Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devbox: update instructions #763

Merged
merged 2 commits into from
Apr 23, 2020
Merged

devbox: update instructions #763

merged 2 commits into from
Apr 23, 2020

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Apr 23, 2020

See https://github.com/aragon/aragon-ui/issues/731#issuecomment-596145523 (should we close it for this?).

Updates the README and adds a warning when starting the devbox if @aragon/ui isn't linked.

Screen Shot 2020-04-23 at 12 19 27 PM

@sohkai sohkai requested a review from bpierre April 23, 2020 10:26
@@ -30,6 +31,7 @@
"file-loader": "^5.0.2",
"html-webpack-plugin": "^3.2.0",
"react-axe": "^3.3.0",
"symlinked": "^0.5.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the most complex package, but I think it's fine as a dev dependency?

Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@sohkai sohkai merged commit 165db9d into master Apr 23, 2020
@sohkai sohkai deleted the update-devbox-instructions branch April 23, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants