Version 1.1.11 - Fixed publishing of empty messages configured throug…

…h config-ui-x in startPub
arachnetech · Apr 28, 2020 · e59dfb4 · e59dfb4
1 parent 82f75ed
commit e59dfb4
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 8 deletions.
diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md
@@ -5,6 +5,9 @@
 
 # Homebridge MQTT-Thing: Release Notes
 
+### Version 1.1.11
++ Fixed publishing of empty messages configured through config-ui-x in startPub
+
 ### Version 1.1.10
 + Fixed crash (introduced in version 1.1.9) with confirmed publisher on/off acknowledgement
 

diff --git a/index.js b/index.js
@@ -2661,7 +2661,9 @@ function makeThing(log, config) {
             if( Array.isArray( config.startPub ) ) {
                 // new format - [ { topic: x, message: y }, ... ]
                 for( let entry of config.startPub ) {
-                    mqttPublish( entry.topic, 'startPub', entry.message );
+                    if( entry.topic ) {
+                        mqttPublish( entry.topic, 'startPub', entry.message || '' );
+                    }
                 }
             } else {
                 // old format - object of topic->message

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "homebridge-mqttthing",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Homebridge plugin supporting various services over MQTT",
   "main": "index.js",
   "scripts": {

diff --git a/test/config.json b/test/config.json
@@ -66,16 +66,21 @@
             "accessory": "mqttthing"
         },
         {
-            "accessory": "mqttthing",
             "type": "lightbulb-HSV",
             "name": "Test HSV Light",
             "url": "http://192.168.10.35:1883",
+            "logMqtt": true,
+            "codec": "test-codec.js",
             "topics": {
-                "getHSV": "test/hsvlight/getHSV",
-                "setHSV": "test/hsvlight/setHSV"
+                "setHSV": "test/hsvlight/setHSV",
+                "getHSV": "test/hsvlight/getHSV"
             },
-            "logMqtt": true,
-            "codec": "test-codec.js"
+            "startPub": [
+                {
+                    "topic": "test/hsvlight/setHSV"
+                }
+            ],
+            "accessory": "mqttthing"
         },
         {
             "accessory": "mqttthing",
@@ -844,7 +849,7 @@
             "offValue": "0",
             "confirmationPeriodms": 1000,
             "retryLimit": 3
-        },        
+        },
         {
             "accessory": "mqttthing",
             "type": "switch",