Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-5967: wallet connection profile menu AR connect #5
PE-5967: wallet connection profile menu AR connect #5
Changes from all commits
616a034
f8a8ea2
bf4d9ad
2c3b327
efdccec
6f635a5
ef94db8
653c34c
bdb365d
9576c47
b4b6cd1
226476e
533c610
170e6db
4b451d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could use a simple and small promise cache for these API calls and avoid the setInterval - https://github.com/ardriveapp/promise-cache
e.g. the hook would be responsible for calling the cache for the height - and with a TTL of two minutes it'll refresh when it needs to based on what's being renedered
you could have a separate cache for the epoch information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think promise-cache might not be the right tool here. We want to trigger a re-render of the app when data changes, which occurs when the polling result comes back and we send an update to the global data store. If promise-cache was added, we would have to poll against the read-through-cache's status to identify when to update the global data store to trigger the re-render.
Also for context, this class isn't a hook, it's more of a global wrapper to the app to have a place for code that can interconnect global data fetching together with our global data store and have it all interact well with react's events and lifecycle.
I think for now it'd be best to keep moving forward and I'll keep promise-cache on my mind to see if it's a good fit for the uses cases coming up.