-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-7263: Stake-redelegation #125
Conversation
kunstmusik
commented
Dec 19, 2024
•
edited
Loading
edited
- Introduces ellipsis button and popup menu to initiate staking, withdrawals, redelegation, expedited withdrawals, and cancel withdrawals.
- Separates Staking and Withdrawals into separate modals
- Introduces Redelegation for stake and pending withdrawals. Works between delegate stake and operator stake.
- Removes quick stake button
- Fixes missing Stake and Leave buttons on gateway details page
…and introduced ellipsis popup menu
Visit the preview URL for this PR (updated for commit 9b11259): https://ar-io-network-portal-a40ee--pr125-pe-7263-stake-redele-yeq4bmad.web.app (expires Thu, 02 Jan 2025 20:24:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7abfae09c4446982a71cbb94b0cbf4688377a111 |
validateOperatorWithdrawAmount, | ||
} from '../forms/validation'; | ||
import { CircleCheckIcon, CircleIcon, InfoIcon } from '../icons'; | ||
import { validateIOAmount as validateARIOAmount } from '../forms/validation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not rename the actual function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was part of refactoring and didn't catch that auto did that, will update now
|
||
const validators = useMemo( | ||
() => ({ | ||
redelegationAmount: validateIOAmount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do a find and replace for validateIOAmount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
setAmountToRedelegate(textValue); | ||
}} | ||
></input> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: <input />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
setAmountToWithdraw(textValue); | ||
}} | ||
></input> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: <input />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
validateOperatorWithdrawAmount, | ||
} from '../forms/validation'; | ||
import { CircleCheckIcon, CircleIcon, InfoIcon } from '../icons'; | ||
import { validateARIOAmount as validateARIOAmount } from '../forms/validation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to do as