Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(balances): return balance as string #303

Merged
merged 4 commits into from
Dec 31, 2024
Merged

fix(balances): return balance as string #303

merged 4 commits into from
Dec 31, 2024

Conversation

dtfiedler
Copy link
Collaborator

@dtfiedler dtfiedler commented Dec 30, 2024

For unknown reasons, the MU does not crank the Balance-Notice message back to a calling process when Data is not a string. This updates all handlers that return numbers to return the strings.

My initial thought was that this would cause breaking changes with the SDK - but given our use of JSON.parse - which parses strings to numbers, it actually has no obvious downstream consequences. We will continue to test in devnet before pushing to testnet, specifically with arns.app, network-portal.app and ArConnect.

Related: ar-io/ar-io-sdk#327

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (7bbe777) to head (36a51c7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #303   +/-   ##
========================================
  Coverage    94.46%   94.46%           
========================================
  Files           10       10           
  Lines         2997     2997           
========================================
  Hits          2831     2831           
  Misses         166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtfiedler dtfiedler changed the title fix(balances): return balance as string dtfiedler committed 1 hour ago fix(balances): return balance as string Dec 30, 2024
@dtfiedler dtfiedler merged commit 945a5a2 into develop Dec 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants