fix(balances): return balance as string #303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reasons, the MU does not crank the
Balance-Notice
message back to a calling process whenData
is not a string. This updates all handlers that return numbers to return the strings.My initial thought was that this would cause breaking changes with the SDK - but given our use of
JSON.parse
- which parses strings to numbers, it actually has no obvious downstream consequences. We will continue to test in devnet before pushing to testnet, specifically with arns.app, network-portal.app and ArConnect.Related: ar-io/ar-io-sdk#327