Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-7351: correctly account for moving stakes during redelegation #299

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

arielmelendez
Copy link
Contributor

Issues found:

  • LastKnownWithdrawSupply being ADDED to rather than subtracted from
  • LastKnownStakedSupply not being added to in the case where a delegation withdraw vault is used to redelegate to a new gateway
  • (minor) incorrect types returned from gar.redelegateStake

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (7edaece) to head (e191e23).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #299   +/-   ##
========================================
  Coverage    94.44%   94.44%           
========================================
  Files           10       10           
  Lines         2990     2990           
========================================
  Hits          2824     2824           
  Misses         166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arielmelendez arielmelendez changed the title PE-7351: correct account for moving stakes during redelegation PE-7351: correctly account for moving stakes during redelegation Dec 26, 2024
@arielmelendez arielmelendez merged commit 4012246 into develop Dec 26, 2024
6 checks passed
@arielmelendez arielmelendez deleted the PE-7351_redelegate_stake_supply branch December 26, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants