Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: address TODOs PE-7339 #296

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Conversation

fedellen
Copy link
Contributor

@fedellen fedellen commented Dec 20, 2024

this PR addresses some of the TODOs. We still have 23 in the codebase, quite a few around improved testing coverage

  • removes timestamp conversion (looks good so far, test this devnet) <-- did not blend, we need this converison
  • gives types for ARIOEvent
  • Adds Buy-Name handler in addition to Buy-Record in preparation for standardizing on Name
  • excises TODOs that are already done or seemed unnecessary
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (7edaece) to head (1d9fd82).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #296      +/-   ##
===========================================
- Coverage    94.44%   94.42%   -0.03%     
===========================================
  Files           10       10              
  Lines         2990     2993       +3     
===========================================
+ Hits          2824     2826       +2     
- Misses         166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants