feat: audit msg.Timestamp, remove input of msg.Tags.Timestamp PE-7338 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #293 +/- ##
========================================
Coverage 94.44% 94.44%
========================================
Files 10 10
Lines 2988 2988
========================================
Hits 2822 2822
Misses 166 166 ☔ View full report in Codecov by Sentry. |
fedellen
commented
Dec 19, 2024
src/main.lua
Outdated
Comment on lines
411
to
421
| --- @class ParsedMessage | ||
| --- @field Id string | ||
| --- @field From string | ||
| --- @field Timestamp number | ||
| --- @field Tags table<string, any> | ||
|
|
||
| --- @param handlerName string | ||
| --- @param pattern fun():string | ||
| --- @param handleFn fun(msg: ParsedMessage) | ||
| --- @param critical boolean? | ||
| --- @param printEvent boolean? |
There was a problem hiding this comment.
gives us IDE types in main.handlers
There was a problem hiding this comment.
will include ioEvent
dtfiedler
previously approved these changes
Dec 19, 2024
fedellen
commented
Dec 19, 2024
src/main.lua
Outdated
| @@ -553,7 +569,7 @@ end, function(msg) | |||
| addSupplyData(msg.ioEvent) | |||
| end | |||
|
|
|||
| return prunedStateResult | |||
| -- return prunedStateResult -- TODO: need to return? | |||
There was a problem hiding this comment.
appears tests work fine without returning here in prune. its the only function returning so the lua type annotations was calling it out -- will remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.