-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gar): optimize prescribed observers, use lookup table and comput… #279
Conversation
…e full array on read handlers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #279 +/- ##
===========================================
- Coverage 94.45% 94.42% -0.04%
===========================================
Files 10 10
Lines 2975 2976 +1
===========================================
Hits 2810 2810
- Misses 165 166 +1 ☔ View full report in Codecov by Sentry. |
Note: the type in the SDK will change, but it was outdated already. It is also not used by any of our downstream apps. Related: ar-io/ar-io-sdk#318 |
if msg.From == ao.id then | ||
LastKnownCirculatingSupply = LastKnownCirculatingSupply + quantity | ||
addSupplyData(msg.ioEvent) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, saw some test errors when looking into that beforeEAch
mystery that might be related to this fix
assert(providedEpochIndex or timestamp, "Epoch index or timestamp is required") | ||
|
||
local epochIndex = providedEpochIndex or epochs.getEpochIndexForTimestamp(timestamp) | ||
local epochIndex = msg.Tags["Epoch-Index"] and tonumber(msg.Tags["Epoch-Index"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is epoch-index already sanitized as number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I think its ready but needs re-integration with latest develop
just FYI - it'll take 14 epochs to prune out all the old state of previous epochs. As mentioned, this type is not used externally anywhere so no breaking change. |
…e full array on read handlers