feat(events): instrument token supply handler PE-6976 #104
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #104 +/- ##
========================================
Coverage 83.14% 83.14%
========================================
Files 8 8
Lines 1685 1685
========================================
Hits 1401 1401
Misses 284 284 ☔ View full report in Codecov by Sentry. |
| lastKnownTotalSupply = totalSupply | ||
| lastKnownCirculatingSupply = circulatingSupply | ||
| lastKnownLockedSupply = lockedSupply | ||
| lastKnownStakedSupply = stakedSupply | ||
| lastKnownDelegatedSupply = delegatedSupply | ||
| lastKnownWithdrawSupply = withdrawSupply | ||
|
|
||
| msg.ioEvent:addField("Total-Token-Supply", lastKnownTotalSupply) | ||
| msg.ioEvent:addField("Circulating-Supply", lastKnownCirculatingSupply) | ||
| msg.ioEvent:addField("Locked-Supply", lastKnownLockedSupply) | ||
| msg.ioEvent:addField("Staked-Supply", lastKnownStakedSupply) | ||
| msg.ioEvent:addField("Delegated-Supply", lastKnownDelegatedSupply) | ||
| msg.ioEvent:addField("Withdraw-Supply", lastKnownWithdrawSupply) | ||
| msg.ioEvent:addField("Protocol-Balance", protocolBalance) |
There was a problem hiding this comment.
FWIW - this is mostly used as a dryRun only handler - so it's unlikely to ever surface event data. that being said, we can move the computation to a separate function and call it before/after every write message and add the event data you've added here
There was a problem hiding this comment.
I was toying with factoring this out and calling it any time functions that affect the supplies get called but I worry that it could get unnecessarily computationally expensive at scale (also from a gas perspective). I haven't ruled it out for ticks so that we get it all at least once a day.
No description provided.