FIX | k3s-cis-*- CHECK 4.2.1-4.2.3 #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aprilpear9696
changed the title
afdesk
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
@aprilpear9696
It seems it makes sense!
thanks for the contribute!
|
@mozillazg wdyt? |
|
cc @andypitcher |
mozillazg
approved these changes
Dec 5, 2024
|
@mozillazg @afdesk Thanks for review. Could you help to reapprove to trigger the required validation before merge? Thanks |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check 4.2.1-4.2.3 for k3s-cis-* is aim to check the node kubelet status. But current test case audit/audit_config commands are targeting kube-apiserver instead of kubelet.
Update the target tests' audit/audit_config command from checking kube-apiserver arguments to checking kubelet ones.