Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1595: failed to output to ASFF #1691

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

w-reichert
Copy link
Contributor

A breaking change was introduced in aws-sdk-go-v2.
See aws/aws-sdk-go-v2#2370 (comment).

Mixing aws-sdk-go-v2 packages from versions before and after the breaking change causes kube-bench to fail. This issue occurs when it attempts to access AWS Security Hub.

Addressed issue: #1595

Supersedes bot PR: #1689
Besides upgrading to latest SDK version, some variable types need to be adapted.

A breaking change was introduced in aws-sdk-go-v2.
See aws/aws-sdk-go-v2#2370 (comment).

Mixing aws-sdk-go-v2 packages from versions before and after the breaking change causes kube-bench to fail. This issue occurs when it attempts to access AWS Security Hub.

Addressed issue: aquasecurity#1595

Supersedes bot PR: aquasecurity#1689
Besides upgrading to latest SDK version, some variable types need to be adapted.
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w-reichert thanks for the contribution!

LGTM

Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@afdesk afdesk merged commit f6877e3 into aquasecurity:main Sep 28, 2024
5 checks passed
deebhatia pushed a commit to VoerEirAB/kube-bench that referenced this pull request Oct 14, 2024
A breaking change was introduced in aws-sdk-go-v2.
See aws/aws-sdk-go-v2#2370 (comment).

Mixing aws-sdk-go-v2 packages from versions before and after the breaking change causes kube-bench to fail. This issue occurs when it attempts to access AWS Security Hub.

Addressed issue: aquasecurity#1595

Supersedes bot PR: aquasecurity#1689
Besides upgrading to latest SDK version, some variable types need to be adapted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants