Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the rh-1.0 OCP checks #1548

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Updating the rh-1.0 OCP checks #1548

merged 2 commits into from
Jan 23, 2024

Conversation

KiranBodipi
Copy link
Contributor

  1. Added audit commands wherever required.
  2. Updated the scripts with type to manual if title contains Manual.
  3. Updated the scripts with test_items wherever required.
  4. Fixed a typo.

@KiranBodipi KiranBodipi force-pushed the kb-rh-1.0-checks-correction branch 4 times, most recently from e617cf3 to 5e9363a Compare January 12, 2024 07:37
deven0t
deven0t reviewed Jan 12, 2024
View reviewed changes
cfg/rh-1.0/node.yaml Outdated Show resolved Hide resolved
@KiranBodipi KiranBodipi force-pushed the kb-rh-1.0-checks-correction branch from 5e9363a to 2a8b6b4 Compare January 12, 2024 13:22
@KiranBodipi
Updating the rh-1.0 OCP checks
f3d53be 
1. Added audit commands wherever required.
2. Updated the scripts with type to manual to match the title.
3. Updated the scripts with test_items wherever required.
4. Fixed a typo.
@KiranBodipi KiranBodipi force-pushed the kb-rh-1.0-checks-correction branch from 6979422 to f3d53be Compare January 19, 2024 04:15
deven0t
deven0t approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@deven0t deven0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KiranBodipi
Copy link
Contributor Author

Hey @chen-keinan can you please help to review and merge this PR

mjshastha
mjshastha approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@mjshastha mjshastha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content with the changes.

@chen-keinan chen-keinan merged commit 13da372 into aquasecurity:main Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjshastha mjshastha mjshastha approved these changes

@deven0t deven0t deven0t approved these changes

@chen-keinan chen-keinan chen-keinan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KiranBodipi @chen-keinan @deven0t @mjshastha