Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoother quick start #1693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dfredell
Copy link

Adding depth of 1 to the git clone to save on network and disk space as only the HEAD is needed for an install.
Also adding permission to execute the index.js file.

Adding a --depth 1 saves about 50% (21M vs 40M) of network and disk.

➜  external mkdir full    
➜  external cd full                 
➜  full git clone https://github.com/aquasecurity/cloudsploit.git      

Cloning into 'cloudsploit'...
remote: Enumerating objects: 38084, done.
remote: Counting objects: 100% (3883/3883), done.
remote: Compressing objects: 100% (1174/1174), done.
remote: Total 38084 (delta 2926), reused 3515 (delta 2701), pack-reused 34201
Receiving objects: 100% (38084/38084), 21.56 MiB | 2.71 MiB/s, done.
Resolving deltas: 100% (29626/29626), done.
➜  full cd ..  
➜  external mkdir depth1
➜  external cd depth1                  
➜  depth1 git clone https://github.com/aquasecurity/cloudsploit.git --depth 1
Cloning into 'cloudsploit'...
remote: Enumerating objects: 2971, done.
remote: Counting objects: 100% (2971/2971), done.
remote: Compressing objects: 100% (1739/1739), done.
remote: Total 2971 (delta 1783), reused 1631 (delta 1216), pack-reused 0
Receiving objects: 100% (2971/2971), 2.79 MiB | 2.01 MiB/s, done.
Resolving deltas: 100% (1783/1783), done.
➜  depth1 cd ..     
➜  external du -sh                             
^C
➜  external du -sh full depth1 
40M	full
21M	depth1
➜  external 

By default the index.js doesn't have execute permission

➜  cloudsploit git:(master) npm install

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@azure/[email protected]',
npm WARN EBADENGINE   required: { node: '>=14.0.0' },
..........
npm WARN deprecated [email protected]: Please note: newer packages @azure/storage-blob, @azure/storage-queue and @azure/storage-file are available as of November 2019 and @azure/data-tables is available as of June 2021. While the legacy azure-storage package will continue to receive critical bug fixes, we strongly encourage you to upgrade. Migration guide can be found: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/storage/MigrationGuide.md

added 903 packages, and audited 904 packages in 30s

80 packages are looking for funding
  run `npm fund` for details

20 vulnerabilities (13 moderate, 4 high, 3 critical)

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
➜  cloudsploit git:(master) ./index.js -h                                               
zsh: permission denied: ./index.js
➜  cloudsploit git:(master) chmod +x index.js                              
➜  cloudsploit git:(master) ✗ ./index.js -h    

   _____ _                 _  _____       _       _ _   
  / ____| |               | |/ ____|     | |     (_) |  
 | |    | | ___  _   _  __| | (___  _ __ | | ___  _| |_ 
 | |    | |/ _ \| | | |/ _` |\___ \| '_ \| |/ _ \| | __|
 | |____| | (_) | |_| | (_| |____) | |_) | | (_) | | |_ 
  \_____|_|\___/ \__,_|\__,_|_____/| .__/|_|\___/|_|\__|
                                   | |                  
                                   |_|                  

  CloudSploit by Aqua Security, Ltd.
  Cloud security auditing for AWS, Azure, GCP, Oracle, and GitHub
....

Adding depth of 1 to the git clone to save on network and disk space as only the HEAD is needed for an install.
Also adding permission to execute the index.js file
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants