Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is purely a refactor. There are no logic changes.
The comments and changelogs are probably not up-to-date any longer. 😬
There was a problem with circular dependencies at some point during the creation of this repo.
I believe this solves that problem, by layering the codebase like this:
The pattern for users will be to use mostly
types
,api
andclient
.Other improvements?
I don't know the codebase well enough to understand how reasonable these recommendations are.
types
andclient
toaptostypes
andaptosclient
. They'll probably clash codebases that import this sdk.api
andclient
.constants
package? For0x1
... etc.Test Plan
The multiple
main_test.go
still build. I added./scripts/build-tests.sh
to verify.