Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipeline] enable on forge #15456

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[pipeline] enable on forge #15456

merged 2 commits into from
Dec 3, 2024

Conversation

zekun000
Copy link
Contributor

@zekun000 zekun000 commented Dec 3, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 3, 2024

⏱️ 1h 44m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 24m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
test-target-determinator 11m 🟩🟩🟩
rust-cargo-deny 6m 🟥🟩🟩🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 5m 🟩🟩🟩🟩🟩
check 3m 🟩
execution-performance / test-target-determinator 3m 🟩
general-lints 2m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
file_change_determinator 48s 🟩🟩🟩🟩
rust-move-tests 37s 🟥

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / test-target-determinator 3m 4m -25%
test-target-determinator 3m 4m -26%

settingsfeedbackdocs ⋅ learn more about trunk.io

Base automatically changed from zekun/tokio to main December 3, 2024 01:20
@zekun000 zekun000 added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Dec 3, 2024

This comment has been minimized.

@zekun000 zekun000 changed the title patch futures [pipeline] enable on forge Dec 3, 2024
@zekun000 zekun000 marked this pull request as ready for review December 3, 2024 02:11
@zekun000 zekun000 requested review from msmouse, danielxiangzl and ibalajiarun and removed request for ibalajiarun and sasha8 December 3, 2024 02:12

This comment has been minimized.

This comment has been minimized.

@zekun000 zekun000 enabled auto-merge (rebase) December 3, 2024 04:00

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite realistic_env_max_load success on 3cf4f3ff21058b86682febae93acabe8196871f9

two traffics test: inner traffic : committed: 14325.81 txn/s, latency: 2776.00 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 5100 ms), latency samples: 5446960
two traffics test : committed: 100.06 txn/s, latency: 1812.12 ms, (p50: 1900 ms, p70: 2000, p90: 2200 ms, p99: 6700 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.277, avg: 1.183", "ConsensusProposalToOrdered: max: 0.308, avg: 0.287", "ConsensusOrderedToCommit: max: 0.302, avg: 0.294", "ConsensusProposalToCommit: max: 0.591, avg: 0.581"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.76s no progress at version 2355938 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.64s no progress at version 2355936 (avg 15.64s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 3cf4f3ff21058b86682febae93acabe8196871f9

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 3cf4f3ff21058b86682febae93acabe8196871f9 (PR)
Upgrade the nodes to version: 3cf4f3ff21058b86682febae93acabe8196871f9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 889.67 txn/s, submitted: 924.36 txn/s, failed submission: 3.37 txn/s, expired: 34.69 txn/s, latency: 3333.91 ms, (p50: 1800 ms, p70: 2200, p90: 13800 ms, p99: 15700 ms), latency samples: 68740
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1328.43 txn/s, submitted: 1331.28 txn/s, failed submission: 2.85 txn/s, expired: 2.85 txn/s, latency: 2317.28 ms, (p50: 2000 ms, p70: 2400, p90: 4200 ms, p99: 5200 ms), latency samples: 121000
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 3cf4f3ff21058b86682febae93acabe8196871f9 passed
Upgrade the remaining nodes to version: 3cf4f3ff21058b86682febae93acabe8196871f9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1398.63 txn/s, submitted: 1403.71 txn/s, failed submission: 5.08 txn/s, expired: 5.08 txn/s, latency: 2218.77 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4800 ms), latency samples: 126580
Test Ok

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 3cf4f3ff21058b86682febae93acabe8196871f9

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 3cf4f3ff21058b86682febae93acabe8196871f9 (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14138.26 txn/s, latency: 2301.96 ms, (p50: 2100 ms, p70: 2200, p90: 2400 ms, p99: 7500 ms), latency samples: 530380
2. Upgrading first Validator to new version: 3cf4f3ff21058b86682febae93acabe8196871f9
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7413.59 txn/s, latency: 3874.02 ms, (p50: 4300 ms, p70: 4500, p90: 4600 ms, p99: 4700 ms), latency samples: 140260
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6752.24 txn/s, latency: 4748.52 ms, (p50: 4700 ms, p70: 4700, p90: 7100 ms, p99: 7500 ms), latency samples: 241080
3. Upgrading rest of first batch to new version: 3cf4f3ff21058b86682febae93acabe8196871f9
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7148.17 txn/s, latency: 3964.70 ms, (p50: 4500 ms, p70: 4800, p90: 4900 ms, p99: 4900 ms), latency samples: 130980
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6560.74 txn/s, latency: 4884.86 ms, (p50: 4900 ms, p70: 4900, p90: 7000 ms, p99: 7200 ms), latency samples: 228200
4. upgrading second batch to new version: 3cf4f3ff21058b86682febae93acabe8196871f9
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 2397.22 txn/s, submitted: 2616.26 txn/s, expired: 219.04 txn/s, latency: 3571.24 ms, (p50: 2600 ms, p70: 2800, p90: 10300 ms, p99: 16000 ms), latency samples: 182119
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4938.47 txn/s, submitted: 4938.62 txn/s, expired: 0.15 txn/s, latency: 2828.60 ms, (p50: 2700 ms, p70: 2900, p90: 4600 ms, p99: 5300 ms), latency samples: 360709
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 3cf4f3ff21058b86682febae93acabe8196871f9 passed
Test Ok

@zekun000 zekun000 merged commit 997f8b9 into main Dec 3, 2024
91 of 92 checks passed
@zekun000 zekun000 deleted the zekun/forge branch December 3, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants