[pipeline] switch from broadcast channel to shared future #15453
+51
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 16m total CI duration on this PR
|
zekun000
requested review from
danielxiangzl,
ibalajiarun and
msmouse
and removed request for
ibalajiarun and
sasha8
msmouse
approved these changes
Dec 2, 2024
| @@ -79,7 +79,7 @@ impl StatelessPipeline for ExecutionSchedulePhase { | |||
| for b in &ordered_blocks { | |||
| if let Some(tx) = b.pipeline_tx().lock().as_mut() { | |||
| tx.rand_tx.take().map(|tx| tx.send(b.randomness().cloned())); | |||
| let _ = tx.order_proof_tx.send(()); | |||
| tx.order_proof_tx.take().map(|tx| tx.send(())); | |||
There was a problem hiding this comment.
shall we expect (assert) take() to return Some?
same all other places.
There was a problem hiding this comment.
probably later, I had a few places that may retry in observer prototype
ibalajiarun
approved these changes
Dec 3, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case we have here is probably more suitable for a shared future with oneshot channel than a broadcast channel.
Broadcast channel has a property of dropping values if exceeds the capacity and receiver will see a RecvError::Lagged error. Using oneshot channel we can do exact once send easily and use shared future to share the result to multiple subscribers.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist