-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructure shared state between StateStore and BufferedState #15451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 47m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
msmouse
force-pushed
the
1202-alden-persisted-state
branch
from
December 2, 2024 22:28
e86870f
to
475aa74
Compare
msmouse
changed the title
ExecutedTrees -> LedgerSummary
restructure shared state between StateStore and BufferedState
Dec 2, 2024
msmouse
force-pushed
the
1202-alden-persisted-state
branch
from
December 2, 2024 23:22
475aa74
to
21693a1
Compare
msmouse
added
the
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
label
Dec 2, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zekun000
approved these changes
Dec 3, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
grao1991
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CurrentState
andSmtAncestors
need to be replaced whenStateStore::reset(&self)
, that's why they were wrapped in an additional layer of Mutexes. This restructures theBufferedState
constructors so that they are not responsible to allocate new instances ofCurrentState
andSmtAncestors
, rather, they now take in those instances as parameters and just set the value of them.Also deleted SmtAncestors under the smt crate and created PersistedState in the DB crate, in preparation for adding more content to the structure.
How Has This Been Tested?
existing coverage
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?