Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating serialization constant in the API #15443

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

ziaptos
Copy link
Contributor

@ziaptos ziaptos commented Dec 2, 2024

Updating serialization constant in the API

How Has This Been Tested?

Existing tests

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 2, 2024

⏱️ 4h 57m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 53m 🟩🟩🟩🟩🟩
execution-performance / test-target-determinator 22m 🟩🟩🟩🟩🟩
rust-smoke-tests 20m 🟥
test-target-determinator 17m 🟩🟩🟩🟩
rust-move-tests 16m 🟥🟩
check 15m 🟩🟩🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
rust-move-tests 6m 🟥
fetch-last-released-docker-image-tag 6m 🟩🟩🟩🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩 (+1 more)
rust-doc-tests 6m 🟥🟩
rust-doc-tests 5m 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@sherry-x sherry-x requested a review from GotenJBZ December 2, 2024 17:59
@sherry-x sherry-x enabled auto-merge (rebase) December 2, 2024 18:06
@ziaptos ziaptos added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Dec 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sherry-x sherry-x added the v1.24 label Dec 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sherry-x sherry-x requested review from zjma and heliuchuan December 2, 2024 20:20

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ Forge suite realistic_env_max_load success on 962ce817439da2d9676e11617aef5f3f558d9d8b

two traffics test: inner traffic : committed: 13923.10 txn/s, latency: 2854.19 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5293840
two traffics test : committed: 100.05 txn/s, latency: 2153.53 ms, (p50: 1400 ms, p70: 2000, p90: 2200 ms, p99: 18300 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.261, avg: 1.420", "ConsensusProposalToOrdered: max: 0.331, avg: 0.297", "ConsensusOrderedToCommit: max: 0.377, avg: 0.363", "ConsensusProposalToCommit: max: 0.670, avg: 0.660"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.19s no progress at version 2301376 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.32s no progress at version 2301374 (avg 15.32s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 962ce817439da2d9676e11617aef5f3f558d9d8b

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 962ce817439da2d9676e11617aef5f3f558d9d8b (PR)
Upgrade the nodes to version: 962ce817439da2d9676e11617aef5f3f558d9d8b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1357.66 txn/s, submitted: 1361.03 txn/s, failed submission: 3.37 txn/s, expired: 3.37 txn/s, latency: 2189.71 ms, (p50: 2100 ms, p70: 2300, p90: 3600 ms, p99: 4600 ms), latency samples: 120780
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1312.21 txn/s, submitted: 1314.95 txn/s, failed submission: 2.74 txn/s, expired: 2.74 txn/s, latency: 2266.39 ms, (p50: 2000 ms, p70: 2400, p90: 3800 ms, p99: 5600 ms), latency samples: 114800
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 962ce817439da2d9676e11617aef5f3f558d9d8b passed
Upgrade the remaining nodes to version: 962ce817439da2d9676e11617aef5f3f558d9d8b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1411.93 txn/s, submitted: 1414.87 txn/s, failed submission: 2.94 txn/s, expired: 2.94 txn/s, latency: 2252.36 ms, (p50: 2100 ms, p70: 2300, p90: 3900 ms, p99: 5400 ms), latency samples: 125060
Test Ok

Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 962ce817439da2d9676e11617aef5f3f558d9d8b

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 962ce817439da2d9676e11617aef5f3f558d9d8b (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14673.11 txn/s, latency: 1994.78 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2500 ms), latency samples: 551880
2. Upgrading first Validator to new version: 962ce817439da2d9676e11617aef5f3f558d9d8b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7268.74 txn/s, latency: 3825.77 ms, (p50: 3800 ms, p70: 4500, p90: 5400 ms, p99: 5700 ms), latency samples: 135200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7335.71 txn/s, latency: 4419.11 ms, (p50: 4500 ms, p70: 4800, p90: 6100 ms, p99: 6300 ms), latency samples: 246480
3. Upgrading rest of first batch to new version: 962ce817439da2d9676e11617aef5f3f558d9d8b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7283.02 txn/s, latency: 3894.81 ms, (p50: 4500 ms, p70: 4600, p90: 4800 ms, p99: 4900 ms), latency samples: 134380
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6689.29 txn/s, latency: 4845.52 ms, (p50: 4800 ms, p70: 4800, p90: 7100 ms, p99: 7300 ms), latency samples: 237480
4. upgrading second batch to new version: 962ce817439da2d9676e11617aef5f3f558d9d8b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11566.53 txn/s, latency: 2416.55 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 2900 ms), latency samples: 204520
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10098.12 txn/s, latency: 3070.86 ms, (p50: 2800 ms, p70: 2900, p90: 3000 ms, p99: 7600 ms), latency samples: 386800
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 962ce817439da2d9676e11617aef5f3f558d9d8b passed
Test Ok

@sherry-x sherry-x merged commit 2dd6b77 into main Dec 2, 2024
48 checks passed
@sherry-x sherry-x deleted the zi/update-constant branch December 2, 2024 21:46
Copy link
Contributor

github-actions bot commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
aptos-release-v1.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

3 similar comments
Copy link
Contributor

github-actions bot commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
aptos-release-v1.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link
Contributor

github-actions bot commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
aptos-release-v1.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link
Contributor

github-actions bot commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
aptos-release-v1.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR v1.24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants