Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of warning when building cargo build --profile ci -p aptos-types #15423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brmataptos
Copy link
Contributor

Description

When running move_pr.sh script we see a build warning in package
aptos-types due to one use expression that is not #[cfg] gated
the same as the code it imports. This removes the warning in output.

How Has This Been Tested?

cargo build --profile ci -p aptos-types before and after the fix shows the warning is removed.

Key Areas to Review

It's possible that this only happens because move_pr is doing a weird set of cargo runs:
cargo build and then cargo nextest to try to ensure files are built normally before testing.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 27, 2024

⏱️ 16m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-cargo-deny 2m 🟩
check-dynamic-deps 38s 🟩
general-lints 27s 🟩
semgrep/ci 23s 🟩
file_change_determinator 10s 🟩
permission-check 3s 🟩
permission-check 2s 🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants