Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Make Function code nicer #15389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Nov 25, 2024

Description

While adding function values, ended up cleaning up function code which was not in a great state. Changes:

  1. Stop using pub(crate) for Function fields,
  2. Group fields as type signature, internals (native or bytecode).

How Has This Been Tested?

Key Areas to Review

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

  • Move Virtual Machine

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 25, 2024

⏱️ 11m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 7m 🟥
rust-cargo-deny 2m 🟩
check-dynamic-deps 36s 🟩
general-lints 27s 🟩
semgrep/ci 22s 🟩
file_change_determinator 10s 🟩
permission-check 4s 🟩
permission-check 2s 🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant