[refactoring] Fix more instances of non-canonical PartialOrd implementations #11475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineethk
requested review from
wrwg,
zjma,
brmataptos and
JoshLind
and removed request for
lightmark and
msmouse
vineethk
commented
Dec 21, 2023
| pub struct FunctionDef { | ||
| name: Symbol, | ||
| start: Position, | ||
| attrs: Vec<String>, | ||
| #[derivative(PartialEq = "ignore")] |
There was a problem hiding this comment.
The implementations PartialEq, PartialOrd, and Ord should agree with each other: https://docs.rs/rust-libcore/latest/core/cmp/trait.PartialOrd.html#how-can-i-implement-partialord
vineethk
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11475 +/- ##
=========================================
- Coverage 69.0% 69.0% -0.1%
=========================================
Files 768 768
Lines 178809 178804 -5
=========================================
- Hits 123428 123397 -31
- Misses 55381 55407 +26 ☔ View full report in Codecov by Sentry. |
zjma
approved these changes
Dec 22, 2023
brmataptos
approved these changes
Dec 23, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent upgrade to Rust 1.74.1 (#11374) added new clippy checks.
One such check was adhering to this rule: https://rust-lang.github.io/rust-clippy/master/index.html#/non_canonical_partial_ord_impl
I have addressed most of the instances in our codebase that violated this rule, and fixed a bug found while doing so (
PartialOrd,PartialEq, andOrdalways need to agree with each other).The only cases currently left in our codebase are because of the use of the external
derivativecrate (basically, due to this issue: mcarton/rust-derivative#115). It looks like thederivativecrate may no longer be maintained, so we may want to look for alternatives (not done in this PR).Test Plan
Existing tests.