Consolidate/update schema queries #51
Conversation
Also adding 'list_measurement_tag_keys' for completeness. Note that this does break backwards compatibility but rust doesn't support optional func params- adding 'None' to schema queries will make them backwards compatible though.
|
Can you fix the build |
yeah sorry I missed that. thanks for the quick review |
| pub async fn list_measurements( | ||
| &self, | ||
| bucket: &str, | ||
| days_ago: Option<i64>, |
There was a problem hiding this comment.
I'm a bit late to this PR, but I'd like to note that this introduces a backwards incompatible change to anyone using one of these 3 functions.
Backwards compatibility could be maintained by restoring the original functions and adding new functions with the extra param. Alternatively (and this would be my preference) we could mention it in the release notes
There was a problem hiding this comment.
@Boudewijn26 that's a valid point, I'll yank version 0.4.6 and bump minor version to v0.5 and create a release note, bumping major version seems to be unnecessary since we haven't reach v1 yet.
Also a clean up seems necessary like perhaps introducing both start and stop optional parameter so that it more closely resembles the API documentation.
I'll do this either today or tomorrow.
Per the docs there is an optional 'start' value, in negative days, that can be added to schema queries. This PR:
Tested on my local influx server with Some() and None values