Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to use tslib and enable remove comments #751

Merged

Conversation

hwangsihu
Copy link
Contributor

If you can't approve tslib related PRs, they should be removed as they are useless.
And I enabled remove comments to reduce the size of the dist folder. It seems to have reduced the build time a little bit.

@hwangsihu hwangsihu closed this Nov 6, 2024
@hwangsihu hwangsihu deleted the changed-to-use-tslib-and-remove-comments branch November 6, 2024 08:53
@hwangsihu hwangsihu restored the changed-to-use-tslib-and-remove-comments branch November 6, 2024 08:55
@hwangsihu hwangsihu reopened this Nov 6, 2024
@hwangsihu
Copy link
Contributor Author

hwangsihu commented Nov 6, 2024

When tslib was enabled, the size of the dist folder was reduced, and tslib was imported as tslib_1 in dist/index.js.

@hwangsihu hwangsihu force-pushed the changed-to-use-tslib-and-remove-comments branch from 9b2b986 to d0eacb8 Compare November 6, 2024 23:06
@hwangsihu hwangsihu force-pushed the changed-to-use-tslib-and-remove-comments branch 2 times, most recently from 9c568aa to f46fa57 Compare November 24, 2024 00:15
@hwangsihu hwangsihu force-pushed the changed-to-use-tslib-and-remove-comments branch from f46fa57 to 6c1777c Compare November 27, 2024 13:51
@LucasB25 LucasB25 merged commit 79d5492 into appujet:main Nov 28, 2024
2 checks passed
@hwangsihu hwangsihu deleted the changed-to-use-tslib-and-remove-comments branch November 29, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants