Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package, config, issue template and format #743

Closed
wants to merge 6 commits into from

Conversation

hwangsihu
Copy link
Contributor

No description provided.

@hwangsihu hwangsihu marked this pull request as draft October 7, 2024 00:13
@hwangsihu hwangsihu marked this pull request as ready for review October 7, 2024 01:53
Copy link
Owner

@appujet appujet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

55e0f84
Explain me why need this ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you know about preprocess ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've heard about it, but I don't know the details lol. But if we remove this, it would be good because we wouldn't need to use quotation marks. Am I mistaken?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to stop doing this kind of thing, if we put that it is for a reason, I asked you to test before making PR!

@hwangsihu
Copy link
Contributor Author

I think tslib is used in production

@LucasB25
Copy link
Collaborator

LucasB25 commented Oct 7, 2024

I think tslib is used in production

It’s a 'devDependencies' otherwise you would see it called in the codes...

@hwangsihu
Copy link
Contributor Author

rollbacked

@appujet
Copy link
Owner

appujet commented Oct 8, 2024

Hi, I'm a bit confused about the purpose of this PR 🤔. Could you provide more details or clarify what changes are being made and why?

@hwangsihu hwangsihu changed the title Update package and format Update package, format, config, and issue template Oct 8, 2024
@hwangsihu hwangsihu changed the title Update package, format, config, and issue template Update package, config, issue template and format Oct 13, 2024
@appujet
Copy link
Owner

appujet commented Oct 14, 2024

Sorry I can't accept your PR

Only updating package
8159fb0

@appujet appujet closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants