Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update locales, packages and setup system #721

Merged
merged 22 commits into from
Sep 13, 2024
Merged

Update locales, packages and setup system #721

merged 22 commits into from
Sep 13, 2024

Conversation

hwangsihu
Copy link
Contributor

I'm so sorry for asking so many pull requests. I forgot I hadn't committed this.

@hwangsihu
Copy link
Contributor Author

I working on a fix for the Setup System. Don't push yet.. I think it would be better to fix this and push it together. I don't want to close the pull request and increase the number. I'll edit the title when it's all done.

@hwangsihu hwangsihu changed the title Update languages Update languages (DO NOT PUSH YET) Sep 9, 2024
@hwangsihu hwangsihu changed the title Update languages (DO NOT PUSH YET) Update locales, packages and setup system Sep 10, 2024
@hwangsihu
Copy link
Contributor Author

Done. I worked with the app so it's one file per commit. Please understand. And the button order looks the best this way i think...

@LucasB25
Copy link
Collaborator

Je travaille sur un correctif pour le système de configuration. Ne le faites pas encore... Je pense qu'il serait préférable de corriger cela et de le mettre en place. Je ne veux pas fermer la demande d'extraction et augmenter le nombre. Je modifierai le titre quand tout sera terminé.

I don't see any fixes in what you did, just change buttons.

@hwangsihu
Copy link
Contributor Author

Well... I've been trying to fix something, but I keep failing, so I guess I'll have to put it off. So I just fixed the mismatched buttons. I was trying to fix the queue loss issue that occurs when you play a previous song.

@hwangsihu
Update typescript and biome, formatting
638cdb6
@hwangsihu
Update languages
f7913a4 
Update korean

config.ts

Update Shoukaku

package.json

config.ts

Update Buttons

Typescript updatee

Changed the button order again

Update typescript and biome, formatting

Update TypeScript

Remove empty block

Format

fix data

Format again
@LucasB25
Copy link
Collaborator

image
The "lint" returns you so many errors?

@LucasB25 LucasB25 merged commit 9c2e1da into appujet:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwangsihu @LucasB25