Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics command #719

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Lyrics command #719

merged 11 commits into from
Sep 12, 2024

Conversation

CharlesNaig
Copy link
Contributor

I created lyrics command using genius api i edited .env, config.ts, locale/EnglishUS.json and added Lyrics.ts

For the other languages well i can't add because it's too many to translate.

image
image

I'm not familar doing the locales but i tried my best to put it in to the lyrics command.

Module Genius Api Added

Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
Adding api token for privacy

Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
Genius Api

Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
Addidng lyrics command using genius api key

Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
@infnibor
Copy link
Contributor

infnibor commented Sep 7, 2024

@hatry4 fix
image
image

Copy link
Contributor

@infnibor infnibor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete $ with Language files "${lyrics}"

Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
@CharlesNaig
Copy link
Contributor Author

is this correct? @infnibor

@infnibor
Copy link
Contributor

infnibor commented Sep 7, 2024

is this correct? @infnibor

Nope, Take into account all the pictures, because this 2 version is correct from the screnna only, and what as a review I did in the language files you do not need to use $, because as you execute the command it will execute, but there will be an unprompted character

@PSTechiee
Copy link

My lyrics command is far better

@CharlesNaig
Copy link
Contributor Author

CharlesNaig commented Sep 7, 2024

@infnibor

How about i remove the locale or language in the lyrics command because i really don't understand how the locale settings works

@infnibor
Copy link
Contributor

infnibor commented Sep 7, 2024

@infnibor

Co powiesz na to, że usunę ustawienia regionalne lub język w poleceniu lyrics, ponieważ naprawdę nie rozumiem, jak działają ustawienia regionalne

It is good as it is at the moment, if you fix what lint biome blew up it should work, although I would depend a little on fine-tuning the command, because it does not fully work correctly, I checked on another song than you gave, which on the genius site has lyrics, and it hit that the lyrics for this song was not found. so something does not quite 100% work

@infnibor
Copy link
Contributor

infnibor commented Sep 7, 2024

My lyrics command is far better

A bit pointless comment, you are commenting on someone's work that he has done, maybe there is a command a bit to refine, but if something does not suit you then you can always add your own as PR if you twer believe that yours is better. This PR is not for stating opinions about the code that we don't even see and about the introduction and refinement of a new command to the project.

@CharlesNaig
Copy link
Contributor Author

Co powiesz na to, że usunę ustawienia regionalne lub język w poleceniu lyrics, ponieważ naprawdę nie rozumiem, jak działają ustawienia regionalne

may I ask Which song your trying to get maybe it not published into the genius lyrics? that why

@infnibor
Copy link
Contributor

infnibor commented Sep 7, 2024

Co powiesz na to, że usunę ustawienia regionalne lub język w poleceniu lyrics, ponieważ naprawdę nie rozumiem, jak działają ustawienia regionalne

czy mogę zapytać, którą piosenkę próbujesz dostać, może nie została opublikowana w genialnym tekście? Z tego powodu

I checked, the song has its reflection in genius, but the command twerds that it does not - song https://www.youtube.com/watch?v=4IwqHYcYEQA, reflection in genius https://genius.com/Kuqe-2115-taki-may-ja-lyrics, I also checked on other cases the same thing, your song works, but the others already too much at least as I test not.

@CharlesNaig
Copy link
Contributor Author

I recently tested a feature that allows me to play random Indian music and view the lyrics. While I can get lyrics from Spotify using a link, I have trouble accessing lyrics for music videos on YouTube (not YouTube Music). To enhance this experience, I plan to add a dedicated lyrics page for longer lyrics.

Updated with pages buttons

Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
removing `

Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
CharlesNaig and others added 3 commits September 10, 2024 01:00
Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
Signed-off-by: Charles Giann Marcelo / Naig <[email protected]>
@LucasB25 LucasB25 merged commit e3dc4cb into appujet:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants