-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update #693
Update #693
Conversation
c162cf4
to
210328c
Compare
Bad lavalink config |
What? |
If you want to edit it, read the documentation carefully, arl is commented out by default and so are its options, the Android client has long been broken and is not used instead of Android Test Suite, and the fact that in the YouTube plugin repo you have the clients listed in this order does not mean that you have to set it that way, you set it according to your own applications e.t.c. |
Your PR will remain open for a while, lavalink changes are not officially published yet |
ok |
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v5...v6) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…/build-push-action-6 Bump docker/build-push-action from 5 to 6
@hwangsihu Please split its modification lavalink to another PR |
What do you mean |
|
Do you mean #696? |
Yea |
It's already at 1.7.0, so should I revert it back to the original? |
Fix by #697 - less translation, and you have the correction right away, the issue of PR consolidation. |
Ok |
Is it okay to commit like this? |
Needs testing and translation.
Signed-off-by: LucasB25 <[email protected]>
Is there a reason to be set in config.ts? I only use it as YouTube, so I will be pushed here every time I commit something. |
do as you did create problems in the requests |
I would recommend closing this PR, and bot info unnecessarily throwing away the work of the Appu, regarding downloading variables from language files, making millions of unnecessary commits - you test locally at your place and make any corrections, because then over 20 commits go to the repo, and most of the changes are pointless if you don't know the meaning and documentation |
In short, the clearer it is, the better for the recipient - a pending commit has a description of what has been changed and, of course, sometimes it happens that corrections are needed, but then either you amend the commit or at least describe it properly, because then 10 commits mean ".". I have no complaints, I just try to make the changes clear even for other contributors, etc. |
No description provided.