Make writing of log file configurable #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the debug logging configuration profile
|
FYI, I've already submitted my details to the contribution form. |
|
I just merged this to the |
|
Brilliant, thanks Frank! |
|
Your contribution is now live in the 5.3.2. release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For us to be able to integrate your SDK in our product we have a 3rd party security requirement that the SDK does not write a debug log file to the Caches directory. In this PR I've made the creation of this log file configurable and left the default behaviour to the existing situation. Hopefully you guys can integrate this one, it would greatly help us. Thanks in advance and don't hesitate to contact me if there's any comments!
Kind regards,
Benjamin van den Hout