forked from mongodb/mongoid
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production Branch #1
Draft
msaffitz
wants to merge
14
commits into
mongoid-4-w-patches
Choose a base branch
from
production
base: mongoid-4-w-patches
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unknown attributes
when cloning process_localized_fields only works from the parent document causing embedded documents with translations to get set to a hash instead of the proper translation
TravisSpangle
approved these changes
Sep 8, 2022
It's not clear that this properly works in HEAD / latest releases. I searched for a commit that would provide this functionality, but was unable to find one. It's possible that it's there in a spot I didn't see; HEAD varies substantially from our branch.
TravisSpangle
approved these changes
Sep 8, 2022
TravisSpangle
approved these changes
Sep 8, 2022
Backport fix for assigning a localized field when attributes is a BSON::Document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.