Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Remove wildcard escape #297

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[DOC] Remove wildcard escape #297

merged 1 commit into from
Sep 5, 2024

Conversation

turbotimon
Copy link
Contributor

Description of the Pull Request (PR):

I propose surrounding the wildcard with ticks for the following reasons:

@DrDaveD
Copy link
Contributor

DrDaveD commented Sep 4, 2024

That looks like a fine change. However you need to do your commit with git commit -s to satisfy the DCO as described in the apptainer project CONTRIBUTING Getting Started section.

@turbotimon
Copy link
Contributor Author

turbotimon commented Sep 5, 2024

@DrDaveD thanks for letting me know and sorry for not reading the CONTRIBUTING up front.

I changed the commit and hope it's fine now

@DrDaveD DrDaveD merged commit 3821d93 into apptainer:main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants