Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

feat: added item freeze functionality to draggable list #279

Merged
merged 18 commits into from
Feb 10, 2023

Conversation

keyurparalkar
Copy link
Contributor

@keyurparalkar keyurparalkar commented Dec 13, 2022

Description

This PR introduces disabling the drag of an item in the draggable list.

Fixes PR Issue

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

🦋 Changeset detected

Latest commit: c97264d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
design-system ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 8:57AM (UTC)

@shadabbuchh
Copy link

shadabbuchh commented Dec 15, 2022

Issues noticed:

  1. When two or more draggable list items are frozen either on top or at the bottom, the gap between the items vanishes and they stick together.
  2. The drag experience is not smooth. Dragging an item towards the bottom pusher it above the item before it.
  3. For frozen items we see the same cursor icon that we see for unfrozen items. This can be confusing for the users.

Please refer the below video for reference:
https://www.loom.com/share/cdb396d49a394254b41f93bb6ee864f8

@keyurparalkar
Copy link
Contributor Author

Issues noticed:

  1. When two or more draggable list items are frozen either on top or at the bottom, the gap between the items vanishes and they stick together.
  2. The drag experience is not smooth. Dragging an item towards the bottom pusher it above the item before it.
  3. For frozen items we see the same cursor icon that we see for unfrozen items. This can be confusing for the users.

Please refer the below video for reference: https://www.loom.com/share/cdb396d49a394254b41f93bb6ee864f8

@shadabbuchh issue 1 is resolved. Issue 2 already exists in the prod.

For issue 3, it is a widget-specific issue i.e. the cursor is managed by the widget that is using it. So I will make changes to the main PR specific to the table widget.

@shadabbuchh
Copy link

All issues are fixed.

@sbalaji1192 sbalaji1192 removed their request for review December 21, 2022 14:41
@shadabbuchh
Copy link

@keyurparalkar the sticky property now does not shift the list item to the top/bottom based on what value we have given.
https://www.loom.com/share/9a0ec3a404254533a203aa030bf12aea

@shadabbuchh
Copy link

All issue are fixed. The new isDragDisabled property is working as expected.

@albinAppsmith albinAppsmith merged commit 815b8f8 into release Feb 10, 2023
@albinAppsmith albinAppsmith deleted the feat/feat-sticky-draggable-list branch February 10, 2023 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants