F!! Created untested seam for EmptyFileCreator #172

Co-Authored-By: Clare Macrae <[email protected]>

ApprovalTests/CMakeLists.txt

@@ -128,6 +128,10 @@ add_library(${PROJECT_NAME}
         utilities/CartesianProduct.h
         utilities/DateUtils.cpp
         utilities/DateUtils.h
+        utilities/EmptyFileCreatorDisposer.cpp
+        utilities/EmptyFileCreatorDisposer.h
+        utilities/EmptyFileCreatorFactory.cpp
+        utilities/EmptyFileCreatorFactory.h
         utilities/ExceptionCollector.h
         utilities/ExceptionCollector.cpp
         utilities/FileUtils.h

ApprovalTests/utilities/EmptyFileCreatorDisposer.cpp

@@ -0,0 +1,17 @@
+#include <sstream>
+#include "EmptyFileCreatorDisposer.h"
+
+namespace ApprovalTests
+{
+
+    EmptyFileCreatorDisposer::EmptyFileCreatorDisposer(EmptyFileCreator creator)
+    {
+        previous_result = std::move(EmptyFileCreatorFactory::currentCreator);
+        EmptyFileCreatorFactory::currentCreator = std::move(creator);
+    }
+
+    EmptyFileCreatorDisposer::~EmptyFileCreatorDisposer()
+    {
+        EmptyFileCreatorFactory::currentCreator = std::move(previous_result);
+    }
+}

ApprovalTests/utilities/EmptyFileCreatorDisposer.h

@@ -0,0 +1,19 @@
+#pragma once
+
+#include "ApprovalTests/utilities/Macros.h"
+#include "EmptyFileCreatorFactory.h"
+
+namespace ApprovalTests
+{
+    class APPROVAL_TESTS_NO_DISCARD EmptyFileCreatorDisposer
+    {
+    private:
+        EmptyFileCreator previous_result;
+
+    public:
+        explicit EmptyFileCreatorDisposer(EmptyFileCreator creator);
+        EmptyFileCreatorDisposer(const EmptyFileCreatorDisposer&) = default;
+
+        ~EmptyFileCreatorDisposer();
+    };
+}

ApprovalTests/utilities/EmptyFileCreatorFactory.cpp

@@ -0,0 +1,15 @@
+#include "ApprovalTests/writers/StringWriter.h"
+#include "EmptyFileCreatorFactory.h"
+namespace ApprovalTests
+{
+
+    void EmptyFileCreatorFactory::defaultCreator(std::string fullFilePath)
+    {
+        StringWriter s("", "");
+        s.write(fullFilePath);
+    }
+
+    EmptyFileCreator EmptyFileCreatorFactory::currentCreator =
+        EmptyFileCreatorFactory::defaultCreator;
+
+}

ApprovalTests/utilities/EmptyFileCreatorFactory.h

@@ -0,0 +1,14 @@
+#pragma once
+#include <functional>
+
+namespace ApprovalTests
+{
+    using EmptyFileCreator = std::function<void(std::string)>;
+
+    class EmptyFileCreatorFactory
+    {
+    public:
+        static void defaultCreator(std::string fullFilePath);
+        static EmptyFileCreator currentCreator;
+    };
+}

ApprovalTests/utilities/FileUtils.cpp

@@ -1,5 +1,6 @@
 #include "ApprovalTests/utilities/FileUtils.h"
 #include "ApprovalTests/writers/StringWriter.h"
+#include "EmptyFileCreatorFactory.h"
 #include "SystemUtils.h"
 
 #include <fstream>
@@ -35,8 +36,7 @@ namespace ApprovalTests
     {
         if (!fileExists(fullFilePath))
         {
-            StringWriter s("", "");
-            s.write(fullFilePath);
+            EmptyFileCreatorFactory::currentCreator(fullFilePath);
         }
     }
 

tests/DocTest_Tests/utilities/FileUtilsTests.cpp

@@ -39,6 +39,14 @@ TEST_CASE("readFileReturnEmptyIfMissing() returns empty string if file is missin
 
 TEST_CASE("check impossible directories don't explode")
 {
-    CHECK(!FileUtils::fileExists(
+        CHECK(!FileUtils::fileExists(
         "../../../../../../../../../../../../../../../../../../../../../a.txt"));
 }
+
+TEST_CASE("Empty File Creation")
+{
+    //auto disposer = ApprovalTests::FileUtils::useEmptyFileCreator([](std::string fileName) {});
+
+}
+
+