Remove prompts for DockerHub creds #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipmb
force-pushed
the
remove-dockerhub-creds
branch
from
8e76911
to
44b1bcf
Compare
They are no longer needed with the latest Codebuild builder.
ipmb
force-pushed
the
remove-dockerhub-creds
branch
from
44b1bcf
to
76e2e35
Compare
|
@ipmb Is there anything I can do here to help? |
|
We should verify that updating an old region stack which still uses these parameters works (I expect it to). And creating a new region works as expected. If so, this should be safe to rollout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are no longer needed with the latest Codebuild builder.